Skip to content

DLPX-86675 Disk quota exceeded when unpacking an upgrade image#44

Merged
prakashsurya merged 1 commit into
developfrom
dlpx/pr/prakashsurya/e3465484-4c8e-42d4-9302-da48df46a469
Jun 27, 2023
Merged

DLPX-86675 Disk quota exceeded when unpacking an upgrade image#44
prakashsurya merged 1 commit into
developfrom
dlpx/pr/prakashsurya/e3465484-4c8e-42d4-9302-da48df46a469

Conversation

@prakashsurya

@prakashsurya prakashsurya commented Jun 26, 2023

Copy link
Copy Markdown
Contributor

It looks like there's a new config directory for the 5.15 kernel, so I think the prior OVERRIDES file is no longer getting applied. This change moves the file to the correct location for the 5.15 kernel. No changes being made to the file contents as part of this change.

Related Work

@prakashsurya prakashsurya force-pushed the dlpx/pr/prakashsurya/e3465484-4c8e-42d4-9302-da48df46a469 branch from 25adfe3 to 551e306 Compare June 26, 2023 15:51
@prakashsurya prakashsurya marked this pull request as ready for review June 26, 2023 16:09
@prakashsurya

prakashsurya commented Jun 26, 2023

Copy link
Copy Markdown
Contributor Author

git-ab-pre-push with changes to all kernel (e.g. to check upgrade image size) is here

@prakashsurya

Copy link
Copy Markdown
Contributor Author

upgrade image is back down to 4.6G with these changes (applied to all kernels):

$ sudo get-property-from-image internal-qa.upgrade.tar VERSION
13.0.0.0-snapshot.20230627015835706+jenkins-selfservice-appliance-build-develop-pre-push-586

$ ls -lh internal-qa.upgrade.tar
-rw-r--r-- 1 delphix staff 4.6G Jun 27 03:48 internal-qa.upgrade.tar

@prakashsurya

Copy link
Copy Markdown
Contributor Author

@sebroy I had to make the following additional changes to get the build to work on all the platforms:

--- a/debian.aws-5.15/config/OVERRIDES
+++ b/debian.aws-5.15/config/OVERRIDES
@@ -18,6 +18,7 @@ CONFIG_WIRELESS=n
 # Disable various "drivers" modules which we don't use.
 #
 CONFIG_ACCESSIBILITY=n
+CONFIG_AMD_PMC=n
 CONFIG_ATA=n
 CONFIG_ATM_DRIVERS=n
 CONFIG_AUXDISPLAY=n
@@ -67,7 +68,6 @@ CONFIG_SFI=n
 CONFIG_SIOX=n
 CONFIG_SLIMBUS=n
 CONFIG_SOUNDWIRE=n
-CONFIG_SPI=n
 CONFIG_SPMI=n
 CONFIG_STAGING=n
 CONFIG_THERMAL=n

are you OK with this?

@sebroy

sebroy commented Jun 27, 2023

Copy link
Copy Markdown
Contributor

@prakashsurya yeah, that seems fine to me. I'm curious to know why the build depends on SPI, but I'm fine with it.

@prakashsurya

Copy link
Copy Markdown
Contributor Author
12:08:11  ERROR: modpost: "__spi_register_driver" [drivers/misc/mei/mei-vsc.ko] undefined!
12:08:11  ERROR: modpost: "spi_sync_locked" [drivers/misc/mei/mei-vsc.ko] undefined!

this was the error, and only on some kernels (e.g. generic)..

seems like the mei-vsc module is currently built, and it depends on a symbol that was no longer being built due to our CONFIG_SPI setting.. I haven't determined why this didn't fail on 5.4.. we might be able to solve this by removing mei-vsc as well (in addition to SPI), but I can look into that in a follow up PR, as it wasn't clear if removing mei-vsc was OK for us to do.. re-enabling SPI seemed safer to me.

@prakashsurya prakashsurya force-pushed the dlpx/pr/prakashsurya/e3465484-4c8e-42d4-9302-da48df46a469 branch from e61749c to e3aed04 Compare June 27, 2023 17:08
@prakashsurya prakashsurya enabled auto-merge (squash) June 27, 2023 17:08
@prakashsurya prakashsurya merged commit 7f5e6ed into develop Jun 27, 2023
@prakashsurya prakashsurya deleted the dlpx/pr/prakashsurya/e3465484-4c8e-42d4-9302-da48df46a469 branch June 27, 2023 17:38
delphix-devops-bot pushed a commit that referenced this pull request May 22, 2024
BugLink: https://bugs.launchpad.net/bugs/2059014

[ Upstream commit 4849775 ]

If the net_cls subsystem is already mounted, attempting to mount it again
in setup_classid_environment() will result in a failure with the error code
EBUSY. Despite this, tmpfs will have been successfully mounted at
/sys/fs/cgroup/net_cls. Consequently, the /sys/fs/cgroup/net_cls directory
will be empty, causing subsequent setup operations to fail.

Here's an error log excerpt illustrating the issue when net_cls has already
been mounted at /sys/fs/cgroup/net_cls prior to running
setup_classid_environment():

- Before that change

  $ tools/testing/selftests/bpf/test_progs --name=cgroup_v1v2
  test_cgroup_v1v2:PASS:server_fd 0 nsec
  test_cgroup_v1v2:PASS:client_fd 0 nsec
  test_cgroup_v1v2:PASS:cgroup_fd 0 nsec
  test_cgroup_v1v2:PASS:server_fd 0 nsec
  run_test:PASS:skel_open 0 nsec
  run_test:PASS:prog_attach 0 nsec
  test_cgroup_v1v2:PASS:cgroup-v2-only 0 nsec
  (cgroup_helpers.c:248: errno: No such file or directory) Opening Cgroup Procs: /sys/fs/cgroup/net_cls/cgroup.procs
  (cgroup_helpers.c:540: errno: No such file or directory) Opening cgroup classid: /sys/fs/cgroup/net_cls/cgroup-test-work-dir/net_cls.classid
  run_test:PASS:skel_open 0 nsec
  run_test:PASS:prog_attach 0 nsec
  (cgroup_helpers.c:248: errno: No such file or directory) Opening Cgroup Procs: /sys/fs/cgroup/net_cls/cgroup-test-work-dir/cgroup.procs
  run_test:FAIL:join_classid unexpected error: 1 (errno 2)
  test_cgroup_v1v2:FAIL:cgroup-v1v2 unexpected error: -1 (errno 2)
  (cgroup_helpers.c:248: errno: No such file or directory) Opening Cgroup Procs: /sys/fs/cgroup/net_cls/cgroup.procs
  #44      cgroup_v1v2:FAIL
  Summary: 0/0 PASSED, 0 SKIPPED, 1 FAILED

- After that change
  $ tools/testing/selftests/bpf/test_progs --name=cgroup_v1v2
  #44      cgroup_v1v2:OK
  Summary: 1/0 PASSED, 0 SKIPPED, 0 FAILED

Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
Link: https://lore.kernel.org/r/20231111090034.4248-3-laoar.shao@gmail.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Manuel Diewald <manuel.diewald@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
delphix-devops-bot pushed a commit that referenced this pull request Nov 10, 2024
BugLink: https://bugs.launchpad.net/bugs/2080594

commit 5d92c7c upstream.

If the ata_port_alloc() call in ata_host_alloc() fails,
ata_host_release() will get called.

However, the code in ata_host_release() tries to free ata_port struct
members unconditionally, which can lead to the following:

BUG: unable to handle page fault for address: 0000000000003990
PGD 0 P4D 0
Oops: Oops: 0000 [#1] PREEMPT SMP NOPTI
CPU: 10 PID: 594 Comm: (udev-worker) Not tainted 6.10.0-rc5 #44
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-2.fc40 04/01/2014
RIP: 0010:ata_host_release.cold+0x2f/0x6e [libata]
Code: e4 4d 63 f4 44 89 e2 48 c7 c6 90 ad 32 c0 48 c7 c7 d0 70 33 c0 49 83 c6 0e 41
RSP: 0018:ffffc90000ebb968 EFLAGS: 00010246
RAX: 0000000000000041 RBX: ffff88810fb52e78 RCX: 0000000000000000
RDX: 0000000000000000 RSI: ffff88813b3218c0 RDI: ffff88813b3218c0
RBP: ffff88810fb52e40 R08: 0000000000000000 R09: 6c65725f74736f68
R10: ffffc90000ebb738 R11: 73692033203a746e R12: 0000000000000004
R13: 0000000000000000 R14: 0000000000000011 R15: 0000000000000006
FS:  00007f6cc55b9980(0000) GS:ffff88813b300000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000003990 CR3: 00000001122a2000 CR4: 0000000000750ef0
PKRU: 55555554
Call Trace:
 <TASK>
 ? __die_body.cold+0x19/0x27
 ? page_fault_oops+0x15a/0x2f0
 ? exc_page_fault+0x7e/0x180
 ? asm_exc_page_fault+0x26/0x30
 ? ata_host_release.cold+0x2f/0x6e [libata]
 ? ata_host_release.cold+0x2f/0x6e [libata]
 release_nodes+0x35/0xb0
 devres_release_group+0x113/0x140
 ata_host_alloc+0xed/0x120 [libata]
 ata_host_alloc_pinfo+0x14/0xa0 [libata]
 ahci_init_one+0x6c9/0xd20 [ahci]

Do not access ata_port struct members unconditionally.

Fixes: 633273a ("libata-pmp: hook PMP support and enable it")
Cc: stable@vger.kernel.org
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: John Garry <john.g.garry@oracle.com>
Link: https://lore.kernel.org/r/20240629124210.181537-7-cassel@kernel.org
Signed-off-by: Niklas Cassel <cassel@kernel.org>
Signed-off-by: Oleksandr Tymoshenko <ovt@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Koichiro Den <koichiro.den@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants