Add NUMA balancing detection and performance warning#679
Conversation
🤖 ds-review-bot Code Reviewv4v3This is a well-scoped, low-risk PR that adds NUMA balancing detection with a non-fatal performance warning at import time in deep_ep/init.py. The implementation is correct and idiomatic. Strengths: (1) It mirrors the existing EP_SUPPRESS_NCCL_CHECK pattern including the int(os.environ.get(..., 0)) idiom. (2) It correctly uses warnings.warn() rather than assert, matching the intent that NUMA balancing is a performance concern (non-fatal), unlike check_nccl_so() which correctly aborts; good use of stacklevel=2 and an actionable remediation command in the message. (3) Files reviewed: 1 📍 未定位到 diff 的评论🔵 suggestion |
NUMA balancing auto-migrates pages between NUMA nodes, which causes severe performance degradation for bandwidth-intensive internode dispatch/combine kernels that use RDMA and NVLink. Detect when /proc/sys/kernel/numa_balancing is non-zero at import time and emit a clear warning telling the user how to disable it. Test Plan: - Verified that `import deep_ep` emits a warning when /proc/sys/kernel/numa_balancing contains "1" - Verified that `import deep_ep` is silent when /proc/sys/kernel/numa_balancing contains "0" or is absent Signed-off-by: Yuchen Fan <functionhx@gmail.com>
d37d89c to
b55e3c1
Compare
Uh oh!
There was an error while loading. Please reload this page.