Expand icon support with Themify, Remix Icon, and Boxicons - #1165
Open
budescode wants to merge 1 commit into
Open
Expand icon support with Themify, Remix Icon, and Boxicons#1165budescode wants to merge 1 commit into
budescode wants to merge 1 commit into
Conversation
Adds THEMIFY, REMIX_ICON, BOXICONS_BASIC, BOXICONS_FILLED, and BOXICONS_BRANDS constants to dbc.icons, following the same pattern as the existing BOOTSTRAP and FONT_AWESOME constants: version-pinned CSS stylesheet URLs served from a CDN, for use in external_stylesheets. Includes unit tests covering existence, type, and URL shape of all icon set constants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds five new icon set constants to
dbc.icons:THEMIFY,REMIX_ICON,BOXICONS_BASIC,BOXICONS_FILLED, andBOXICONS_BRANDS.Motivation
dbc.iconscurrently offers Bootstrap Icons and Font Awesome. Themify, RemixIcon, and Boxicons are popular free icon fonts, and exposing them as constants
gives users the same one-line experience
(
external_stylesheets=[dbc.icons.REMIX_ICON]) instead of hunting down andhardcoding CDN URLs.
Implementation
Purely additive five version-pinned CSS stylesheet URLs following the exact
pattern of the existing
BOOTSTRAPandFONT_AWESOMEconstants. No behaviorchanges anywhere else. All URLs verified to resolve (HTTP 200). Boxicons v3
splits its font into basic/filled/brands stylesheets, hence three constants.
Includes unit tests covering existence, type, and URL shape of all icon set
constants.