Skip to content

feat: add Tormenta RPG provider#1802

Merged
kingthorin merged 10 commits into
datafaker-net:mainfrom
lvspa:feat/tormenta-provider
Apr 30, 2026
Merged

feat: add Tormenta RPG provider#1802
kingthorin merged 10 commits into
datafaker-net:mainfrom
lvspa:feat/tormenta-provider

Conversation

@lvspa

@lvspa lvspa commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

Added the Tormenta RPG provider (a famous Brazilian RPG heavily inspired by D&D). Includes bestiary, character names, and cities. Follows the Dungeons & Dragons standard.

@what-the-diff

what-the-diff Bot commented Apr 24, 2026

Copy link
Copy Markdown

PR Summary

  • Introduction of Tormenta provider
    This change includes a new functional class called Tormenta. It's made exclusively to assist with tasks specific to the Tormenta RPG, such as accessing information about certain creatures, names, and cities.

  • Modification to BaseProviders
    The BaseProviders has been updated with a method called tormenta(). This offers an easy way to access an instance of Tormenta, thus enhancing the usefulness of the BaseProviders.

  • Creation of Localization file
    We've added a new localization file named 'tormenta.yml'. It stores collections of creature types, names, and cities related to the Tormenta RPG, making it easier for users to access and utilize this information.

  • New Tests for Tormenta
    To ensure the smooth operation of the Tormenta provider, a relevant test class named TormentaTest.java was created. It helps verify that the Tormenta provider is delivering the expected results consistently.

@asolntsev asolntsev added this to the 2.6.0 milestone Apr 25, 2026
@asolntsev
asolntsev self-requested a review April 25, 2026 13:16
@asolntsev

Copy link
Copy Markdown
Collaborator

@lvspa Are these names only in English? Maybe you want to add the same names in Portuguese too?

@asolntsev

Copy link
Copy Markdown
Collaborator

compilation error:

13:16:14.047 [ERROR] /home/runner/work/datafaker/datafaker/src/main/java/net/datafaker/providers/base/BaseProviders.java:[3,83] package com.project.data.faker.datafaker.src.main.java.net.datafaker.providers.base does not exist

@lvspa

lvspa commented Apr 25, 2026

Copy link
Copy Markdown
Contributor Author

Hi @asolntsev !

Thank you for the feedback!

Regarding the translation, these are proper names specifically created for the Tormenta RPG setting. Since they are fictional proper nouns (fantasy names), they don't have a direct translation or a different version in Portuguese, they are used as-is in both languages.

I also apologize for the directory structure issues in the previous commits. I had some local environment and IDE configuration issues that caused the incorrect package paths. I have now performed a clean rebase, corrected the directory hierarchy to net.datafaker.providers.base, and ensured everything follows the project standard.

I'm really enjoying contributing to Datafaker and I plan to submit more PRs soon, specifically focusing on data that would be very valuable for Brazilian professional contexts, such as Brazilian phone numbers (landlines and mobile) and other localized formats.

Thanks for your patience and for maintaining this great project! 👍🏼

@asolntsev asolntsev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this PR has 418 changed files.
Apparently, the folder "out" shouldn't be committed. @lvspa

@lvspa

lvspa commented Apr 25, 2026

Copy link
Copy Markdown
Contributor Author

I apologize for that; it was a silly mistake that went unnoticed. I'm still adjusting to the new development environment I'm using. Anyway, the error has been corrected. I hope everything works out now; I'm really excited to get it up and running :)

@kingthorin

Copy link
Copy Markdown
Collaborator

Have a look at the "Files changed" tab.

@lvspa

lvspa commented Apr 25, 2026

Copy link
Copy Markdown
Contributor Author

I believe it's finally clean now @kingthorin, thks!

I must apologize for the back-and-forth and the extra noise in this PR. I'm still getting used to how IntelliJ IDEA handles local artifacts and project structures, and I didn't realize it was 'auto-including' so much junk (like the out folder and local test files) into my commits.

It was a tough battle against the IDE, but I’ve now manually scrubbed the branch. I’ve removed the Main.java test file, cleared the build artifacts, and ensured that only the relevant files for the Tormenta provider are included in the 'Files changed' tab.

Thank you so much for your patience.

@asolntsev asolntsev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you didn't need to change files "vcs.xml" and "mvnw.cmd‎".

@kingthorin

Copy link
Copy Markdown
Collaborator

The D&D and Chuck Norris changes should also be reverted.

@asolntsev asolntsev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better.

  1. Except one disappeared empty line :)
  2. And the file vcs.xml was deleted. Did you delete it intentionally? (as to me, it's ok to delete this file - it should not be stored in git)

return getProvider(CowboyBebop.class, CowboyBebop::new);
}

default Departed departed() {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The empty line between methods cowboyBebop and departed in EntertainmentProviders.java‎ has disappeared.

…viders.java. It also fixes the same problem in BaseProviders.java.
@kingthorin

Copy link
Copy Markdown
Collaborator

This still isn't right, I'll try to sort it out in a bit.

The vcs file still has changes, there's unnecessary blank line removals and places in new code lacking blanks. There's also a weird package and import change in the tests.

Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.29%. Comparing base (2e8ef4d) to head (79f586b).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1802      +/-   ##
============================================
+ Coverage     92.24%   92.29%   +0.05%     
- Complexity     3479     3485       +6     
============================================
  Files           341      342       +1     
  Lines          6838     6844       +6     
  Branches        670      670              
============================================
+ Hits           6308     6317       +9     
+ Misses          362      360       -2     
+ Partials        168      167       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kingthorin

Copy link
Copy Markdown
Collaborator

@asolntsev I believe this is good to go now.

I changed this to be modeled based on the WorldOfWarcraft provider.

@kingthorin
kingthorin merged commit eed1e08 into datafaker-net:main Apr 30, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants