feat: add Tormenta RPG provider#1802
Conversation
PR Summary
|
|
@lvspa Are these names only in English? Maybe you want to add the same names in Portuguese too? |
|
compilation error: 13:16:14.047 [ERROR] /home/runner/work/datafaker/datafaker/src/main/java/net/datafaker/providers/base/BaseProviders.java:[3,83] package com.project.data.faker.datafaker.src.main.java.net.datafaker.providers.base does not exist |
|
Hi @asolntsev ! Thank you for the feedback! Regarding the translation, these are proper names specifically created for the Tormenta RPG setting. Since they are fictional proper nouns (fantasy names), they don't have a direct translation or a different version in Portuguese, they are used as-is in both languages. I also apologize for the directory structure issues in the previous commits. I had some local environment and IDE configuration issues that caused the incorrect package paths. I have now performed a clean rebase, corrected the directory hierarchy to net.datafaker.providers.base, and ensured everything follows the project standard. I'm really enjoying contributing to Datafaker and I plan to submit more PRs soon, specifically focusing on data that would be very valuable for Brazilian professional contexts, such as Brazilian phone numbers (landlines and mobile) and other localized formats. Thanks for your patience and for maintaining this great project! 👍🏼 |
|
I apologize for that; it was a silly mistake that went unnoticed. I'm still adjusting to the new development environment I'm using. Anyway, the error has been corrected. I hope everything works out now; I'm really excited to get it up and running :) |
|
Have a look at the "Files changed" tab. |
|
I believe it's finally clean now @kingthorin, thks! I must apologize for the back-and-forth and the extra noise in this PR. I'm still getting used to how IntelliJ IDEA handles local artifacts and project structures, and I didn't realize it was 'auto-including' so much junk (like the out folder and local test files) into my commits. It was a tough battle against the IDE, but I’ve now manually scrubbed the branch. I’ve removed the Main.java test file, cleared the build artifacts, and ensured that only the relevant files for the Tormenta provider are included in the 'Files changed' tab. Thank you so much for your patience. |
asolntsev
left a comment
There was a problem hiding this comment.
I think you didn't need to change files "vcs.xml" and "mvnw.cmd".
|
The D&D and Chuck Norris changes should also be reverted. |
asolntsev
left a comment
There was a problem hiding this comment.
Looks much better.
- Except one disappeared empty line :)
- And the file
vcs.xmlwas deleted. Did you delete it intentionally? (as to me, it's ok to delete this file - it should not be stored in git)
| return getProvider(CowboyBebop.class, CowboyBebop::new); | ||
| } | ||
|
|
||
| default Departed departed() { |
There was a problem hiding this comment.
The empty line between methods cowboyBebop and departed in EntertainmentProviders.java has disappeared.
…viders.java. It also fixes the same problem in BaseProviders.java.
|
This still isn't right, I'll try to sort it out in a bit. The vcs file still has changes, there's unnecessary blank line removals and places in new code lacking blanks. There's also a weird package and import change in the tests. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1802 +/- ##
============================================
+ Coverage 92.24% 92.29% +0.05%
- Complexity 3479 3485 +6
============================================
Files 341 342 +1
Lines 6838 6844 +6
Branches 670 670
============================================
+ Hits 6308 6317 +9
+ Misses 362 360 -2
+ Partials 168 167 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@asolntsev I believe this is good to go now. I changed this to be modeled based on the WorldOfWarcraft provider. |
Added the Tormenta RPG provider (a famous Brazilian RPG heavily inspired by D&D). Includes bestiary, character names, and cities. Follows the Dungeons & Dragons standard.