chore: update star wars provider#1723
Conversation
PR Summary
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds content from "The Mandalorian" series to the Star Wars provider, expanding the available characters, droids, and vehicles.
- Adds 9 new characters to the characters list, including Din Djarin (The Mandalorian), Grogu (Baby Yoda), and other key characters from the series
- Updates the Java CHARACTERS array with 4 new characters that support quotes and alternate spellings
- Adds the IG-11 droid and Razor Crest vehicle
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/resources/en/star_wars.yml | Adds 9 Mandalorian characters to the characters list, IG-11 to droids, Razor Crest to vehicles, quotes for 3 characters, and alternate spellings for 4 characters |
| src/main/java/net/datafaker/providers/entertainment/StarWars.java | Updates CHARACTERS array to include din_djarin, grogu, kuiil, and moff_gideon in alphabetical order |
| "jar_jar_binks", "k_2so", "kylo_ren", "lando_calrissian", "leia_organa", "luke_skywalker", "mace_windu", | ||
| "maz_kanata", "obi_wan_kenobi", "padme_amidala", "qui_gon_jinn", "rey", "shmi_skywalker", "yoda"}; | ||
| "bendu", "boba_fett", "c_3po", "count_dooku", "darth_caedus", "darth_vader", "din_djarin", "emperor_palpatine", | ||
| "finn", "general_hux", "grand_admiral_thrawn", "grand_moff_tarkin", "greedo", "grogu", "han_solo", |
There was a problem hiding this comment.
The character "grogu" was added to the CHARACTERS array but is missing a corresponding entry in the quotes section of the YAML file. When quotes() randomly selects "grogu", it will fail to resolve star_wars.quotes.grogu.
Since Grogu is a non-verbal character (an infant), consider either:
- Adding at least one quote entry for grogu (perhaps "(coos)" or a description)
- Removing grogu from the CHARACTERS array if quotes should not be available for this character
| "finn", "general_hux", "grand_admiral_thrawn", "grand_moff_tarkin", "greedo", "grogu", "han_solo", | |
| "finn", "general_hux", "grand_admiral_thrawn", "grand_moff_tarkin", "greedo", "han_solo", |
There was a problem hiding this comment.
There should be a test that catches this.
(Not necessarily for this PR, there are likely other providers that could have a similar issue)
There was a problem hiding this comment.
Shouldn't we address this before merging it? I'm not 100% sure if Copilot is correct, but it's a nice catch if it is.
There was a problem hiding this comment.
The situation here should be addressed.
I meant the test(ing) could potentially wait.
There was a problem hiding this comment.
Should I do anything else?
I saw a lot of checks no successful...
There was a problem hiding this comment.
The failure is likely due to the situation that copilot has outlined here, you'll need to fix it
There was a problem hiding this comment.
Updated quotes for din_djarin and add one for grogu
There was a problem hiding this comment.
All tests seem to pass. I'm happy to merge it. What you @kingthorin ?
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1723 +/- ##
=========================================
Coverage 92.27% 92.27%
Complexity 3432 3432
=========================================
Files 337 337
Lines 6779 6779
Branches 670 670
=========================================
Hits 6255 6255
Misses 356 356
Partials 168 168 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks! |
Fixes #1720