Skip to content

Refactoring#1569

Merged
kingthorin merged 6 commits into
mainfrom
refactoring
Jun 20, 2025
Merged

Refactoring#1569
kingthorin merged 6 commits into
mainfrom
refactoring

Conversation

@asolntsev

@asolntsev asolntsev commented Jun 20, 2025

Copy link
Copy Markdown
Collaborator

fix IDEA warnings, apply its automatic suggestions.

@asolntsev asolntsev added this to the 2.4.4 milestone Jun 20, 2025
@asolntsev asolntsev self-assigned this Jun 20, 2025
@what-the-diff

what-the-diff Bot commented Jun 20, 2025

Copy link
Copy Markdown

PR Summary

  • File Separator Handling Improvement
    In the File.java, an import was added that allows better handling of file separators which accommodates varying systems.

  • Enhancements in FakeValuesGrouping.java
    The class was altered to be strictly 'public'. This means it can be accessed universally. There are also two new ways to create 'FakeValuesGrouping' with varying parameters.

  • Warning Removal in Range.java
    A warning was removed in Range.java, this improves the clarity and quality of the code.

  • Improvement in CommerceTest.java
    The price assertions are now using a standard decimal format. This eliminates errors that could occur due to locale-specific decimal separators.

  • Better Encapsulation In Various Tests
    In several testing files, field declarations were secured from outside access by declaring them 'private final'. This change helps in maintaining the integrity of the data used for testing.

  • Better Safety and Clarity in ProviderGenerator.java
    Risk of null pointer exceptions has been mitigated by adding safety checks. Type parameters were also better defined for a clearer understanding and increased type safety.

  • Test Setup Simplification
    In both FakeValuesGroupingTest.java and FakeValuesTest.java, testing setup has been simplified. This was accomplished by initializing necessary values directly, removing the need for unnecessary setup code, and improving clarity and performance.

to avoid the potential risk that some test might modify the field value thus affecting other tests.
initialize test fields right in the field declaration line. The makes unneeded `@BeforeEach` method.
@codecov-commenter

codecov-commenter commented Jun 20, 2025

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.44%. Comparing base (cee4f6d) to head (f10f225).
⚠️ Report is 238 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1569      +/-   ##
============================================
+ Coverage     92.42%   92.44%   +0.01%     
- Complexity     3328     3329       +1     
============================================
  Files           330      330              
  Lines          6550     6554       +4     
  Branches        643      643              
============================================
+ Hits           6054     6059       +5     
  Misses          340      340              
+ Partials        156      155       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kingthorin
kingthorin merged commit 73beb31 into main Jun 20, 2025
13 checks passed
@kingthorin
kingthorin deleted the refactoring branch June 20, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants