Skip to content

Cleanup release process.#1533

Merged
kingthorin merged 1 commit into
mainfrom
cleanup
Apr 7, 2025
Merged

Cleanup release process.#1533
kingthorin merged 1 commit into
mainfrom
cleanup

Conversation

@bodiam

@bodiam bodiam commented Apr 7, 2025

Copy link
Copy Markdown
Contributor

There's still an error in the create-new-PR part, somewhere here:

        git commit -m "Update pom SNAPSHOT version" -m "A release just completed, this PR increments the SNAPSHOT version in pom.xml" --signoff
        git push --set-upstream origin $BRANCH --force
        gh pr create --fill

See https://github.com/datafaker-net/datafaker/actions/runs/14307537882/job/40094866379

But it seems the 2.4.3 release has been created. Also, I thought this might be nice to share:

image

1M is within reach!!!

@what-the-diff

what-the-diff Bot commented Apr 7, 2025

Copy link
Copy Markdown

PR Summary

  • Elimination of "Update Release Notes" step
    This change entails doing away with the step that undertakes the task of modification and confirmation of changes that occur in the release-from-tag.yml workflow.

  • Removal of release.yml workflow
    The entire release.yml workflow procedure, consisting of steps like compiling, setting up various functionalities, and publication to the Maven Central Repository, is removed. Other features deleted alongside comprise of automatic generation of a changelog and launching GitHub releases.

  • Preservation of call_pom_update step
    This update ensures that within the release-from-tag.yml workflow, the process that initiates the pom_update.yml workflow remains operational, particularly after the publish activity.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.53%. Comparing base (57087ed) to head (8912dbd).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1533      +/-   ##
============================================
+ Coverage     92.48%   92.53%   +0.04%     
- Complexity     3275     3276       +1     
============================================
  Files           325      325              
  Lines          6440     6440              
  Branches        625      625              
============================================
+ Hits           5956     5959       +3     
+ Misses          334      332       -2     
+ Partials        150      149       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kingthorin

Copy link
Copy Markdown
Collaborator

If we're comfortable that it works properly it could just push directly instead of raising a PR.

I think a PR is safer but 🤷‍♂️

I guess the readme also needs its snapshot reference updated each time

@kingthorin
kingthorin merged commit 49f706a into main Apr 7, 2025
@kingthorin
kingthorin deleted the cleanup branch April 7, 2025 14:29
@asolntsev asolntsev added this to the 2.4.3 milestone Apr 7, 2025
@bodiam

bodiam commented Apr 7, 2025

Copy link
Copy Markdown
Contributor Author

@kingthorin I'm not sure. I think there's something wrong with the --fill part, maybe putting an explicit --title and --body would be more safe? I couldn't figure out the root cause why the fill didn't work. I like sending the PR though, though pushing directly is fine as well with me.

@erikpragt-connectid

Copy link
Copy Markdown

Just want to say: I probably shouldn't have called this version 2.4.3. I think 2.5 would have better covered the release perhaps. My bad.

@kingthorin

Copy link
Copy Markdown
Collaborator

Need to be careful if deciding to change on the fly, things like @SInCE annotations or comments could end up being wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants