Cleanup release process.#1533
Conversation
PR Summary
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1533 +/- ##
============================================
+ Coverage 92.48% 92.53% +0.04%
- Complexity 3275 3276 +1
============================================
Files 325 325
Lines 6440 6440
Branches 625 625
============================================
+ Hits 5956 5959 +3
+ Misses 334 332 -2
+ Partials 150 149 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
If we're comfortable that it works properly it could just push directly instead of raising a PR. I think a PR is safer but 🤷♂️ I guess the readme also needs its snapshot reference updated each time |
|
@kingthorin I'm not sure. I think there's something wrong with the |
|
Just want to say: I probably shouldn't have called this version 2.4.3. I think 2.5 would have better covered the release perhaps. My bad. |
|
Need to be careful if deciding to change on the fly, things like @SInCE annotations or comments could end up being wrong |
There's still an error in the create-new-PR part, somewhere here:
See https://github.com/datafaker-net/datafaker/actions/runs/14307537882/job/40094866379
But it seems the 2.4.3 release has been created. Also, I thought this might be nice to share:
1M is within reach!!!