Skip to content

Unify geospatial parsing and check failure messages - #1579

Open
ghanse wants to merge 1 commit into
mainfrom
unify-geospatial-parsing
Open

ghanse wants to merge 1 commit into
mainfrom
unify-geospatial-parsing

Conversation

@ghanse

@ghanse ghanse commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Changes

This PR unifies geospatial checks to allow native GEOMETRY and GEOGRAPHY columns. Users can set convert_column=False to apply DQX's built-in checks to native geospatial-typed DataFrame columns.

This PR also introduces new handling for invalid string representations in geospatial columns. When values cannot be parsed due to an invalid representation, checks fail with a message indicating the value is not a valid representation.

Linked issues

Resolves #1513

Tests

  • manually tested
  • added unit tests
  • added integration tests
  • added end-to-end tests
  • added performance tests

Documentation and Demos

  • added/updated demos
  • added/updated docs
  • added/updated agent skills

@ghanse
ghanse requested a review from a team as a code owner October 8, 2026 22:20
@ghanse
ghanse requested review from alexott and removed request for a team October 8, 2026 22:20
@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.97%. Comparing base (b645540) to head (4d55eb7).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1579       +/-   ##
===========================================
+ Coverage   79.39%   92.97%   +13.58%     
===========================================
  Files         142      142               
  Lines       14210    14225       +15     
  Branches      151      151               
===========================================
+ Hits        11282    13226     +1944     
+ Misses       2859      930     -1929     
  Partials       69       69               
Flag Coverage Δ
anomaly 50.86% <4.54%> (-0.06%) ⬇️
anomaly-serverless 50.87% <4.54%> (-0.06%) ⬇️
integration 44.04% <95.45%> (?)
integration-serverless 48.99% <95.45%> (?)
mcp 80.34% <ø> (ø)
unit 66.88% <86.36%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

✅ 1103/1103 passed, 50 skipped, 5h15m11s total

Running from acceptance #6134

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

✅ 1/1 passed, 24m30s total

Running from mcp #883

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

✅ 195/195 passed, 1 skipped, 7h55m48s total

Running from anomaly #2248

This branch was successfully deployed

1 active deployment
tool — 4d55eb7a Deployed Oct 8, 2026 by ghanse via mcp-tests #883
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Unify parsing semantics for geospatial checks

1 participant