Use enum for selection type input parameters - #110
Merged
Conversation
arpitjasa-db
approved these changes
Nov 2, 2023
arpitjasa-db
left a comment
arpitjasa-db
left a comment
Contributor
There was a problem hiding this comment.
LGTM once the CLI is updated! Thanks @shreyas-goenka !
mingyu89
approved these changes
Nov 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR switches to enum fields for relevant input parameters. This allows for a better selection UX.
Note, this PR depends on a CLI version which would have this PR included: databricks/cli#916. We will need to first set a correct
min_cli_versionbefore merging this.Tests
Tested Manually. The video below shows what the initialization experience looks like now:
Screen.Recording.2023-10-25.at.1.22.36.PM.mov