Skip to content

Add configuration view and functionality to attach clusters - #26

Merged
fjakobs merged 4 commits into
mainfrom
config-view
Jul 8, 2022
Merged

Add configuration view and functionality to attach clusters#26
fjakobs merged 4 commits into
mainfrom
config-view

Conversation

@fjakobs

@fjakobs fjakobs commented Jul 7, 2022

Copy link
Copy Markdown
Contributor
Attach.cluster.mov

@fjakobs
fjakobs requested a review from pietern July 7, 2022 07:17

@pietern pietern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the structure looks good, but I don't have experience with vscode extensions. Comments are rather generic.

Comment thread packages/databricks-vscode/src/cluster/ClusterListDataProvider.ts
Comment thread packages/databricks-vscode/src/cluster/ClusterModel.ts
Comment thread packages/databricks-vscode/src/cluster/ClusterModel.ts
Comment thread packages/databricks-vscode/src/configuration/ConnectionManager.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants