Generate code for the cluster API - #24
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't work yet.
When I run
yarn testunderpackages/databricks-vscodeI get:The file
cluster.tsis entirely generated. For code, see https://github.com/databricks/eng-dev-ecosystem/pull/3.@fjakobs No need to merge this until it works end-to-end. If you have time you might want to take a look at fixing downstream usage. Integration pains w.r.t. naming of these things illustrate that we should be using generated code sooner rather than later. Too much room for ambiguity and errors.