fix(query): use jiff to_zoned for naive datetime timezone resolution - #19647
Merged
Conversation
KKould
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
string_to_timestamp_tz used a "fake UTC" approach to resolve timezone
offset for naive datetime inputs: it treated the naive datetime as UTC,
then looked up the timezone offset at that (wrong) UTC instant. This
produced incorrect results when the fake and real UTC instants straddled
a DST transition.
For example, '2024-11-03 05:30:00' in America/New_York should resolve
to EST (-0500), giving real UTC 10:30. But the old code treated 05:30
as UTC to look up the offset, and since 05:30 UTC is before the 06:00
UTC transition, it got EDT (-0400) instead of EST (-0500).
Fix: replace the manual fake-UTC-then-lookup with jiff's
DateTime::to_zoned(), which correctly interprets a naive datetime in
the target timezone and handles DST disambiguation natively.
Tests
Type of change
This change is