refactor: remove environment variable configuration for metasrv - #19333
Merged
Conversation
Remove `ConfigViaEnv` struct and environment variable loading from metasrv config system. Configuration is now supported only via TOML config files and CLI arguments. The `METASRV_CONFIG_FILE` env var for specifying the config file path is preserved. Changes: - Remove `ConfigViaEnv` struct and its `From`/`Into` implementations - Remove env loading step from `Config::load()` - Remove tests for `METASRV_LOG_LEVEL` and `KVSRV_API_PORT` env overrides Upgrade tip: Environment variables like `METASRV_LOG_LEVEL`, `KVSRV_API_PORT`, etc. no longer work for configuring metasrv. Migrate to one of: - TOML config file (use `METASRV_CONFIG_FILE` env var or `--config-file` to specify path) - CLI arguments (e.g., `--log-level DEBUG`, `--raft-api-port 28004`)
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
drmingdrmer
changed the title
github-actions
Bot
added
the
pr-refactor
xp-trumpet
approved these changes
Jan 25, 2026
xp-trumpet
left a comment
xp-trumpet
left a comment
Collaborator
There was a problem hiding this comment.
@xp-trumpet reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @drmingdrmer).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
change: remove environment variable configuration for metasrv
Remove
ConfigViaEnvstruct and environment variable loading frommetasrv config system. Configuration is now supported only via TOML
config files and CLI arguments. The
METASRV_CONFIG_FILEenv var forspecifying the config file path is preserved.
Changes:
ConfigViaEnvstruct and itsFrom/IntoimplementationsConfig::load()METASRV_LOG_LEVELandKVSRV_API_PORTenv overridesUpgrade tip:
Environment variables like
METASRV_LOG_LEVEL,KVSRV_API_PORT, etc.no longer work for configuring metasrv. Migrate to one of:
METASRV_CONFIG_FILEenv var or--config-fileto specify path)--log-level DEBUG,--raft-api-port 28004)Tests
Type of change
Related Issues
This change is