fix: add TrackingPayloadExt trait for ergonomic future tracking - #19296
Merged
Conversation
drmingdrmer
force-pushed
the
367-fix-tracking
branch
from
January 19, 2026 17:58
3178074 to
4675de2
Compare
![chatgpt-codex-connector[bot]](https://avatars.github.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 317807497e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Add an extension trait that provides a more fluent API for tracking futures with payload. This replaces the verbose static method pattern with a method call directly on the payload. Changes: - Add `TrackingPayloadExt` trait with `tracking()` method for `TrackingPayload`, `Arc<TrackingPayload>`, and `Option` variants - Update all call sites to use `payload.tracking(future)` instead of `ThreadTracker::tracking_future_with_payload(future, payload)` - Remove redundant `ThreadTracker::tracking(payload)` guard patterns where the payload is immediately used with `tracking()` - Simplify `InFlightRequest` in grpc_service by removing thread guard field
drmingdrmer
force-pushed
the
367-fix-tracking
branch
from
January 20, 2026 03:15
4675de2 to
e9562a7
Compare
zhang2014
reviewed
Jan 20, 2026
zhang2014
reviewed
Jan 20, 2026
| /// do_work().await | ||
| /// }).await; | ||
| /// ``` | ||
| pub trait TrackingPayloadExt { |
Member
There was a problem hiding this comment.
Perhaps we can remove the traits? The code has become more complex
zhang2014
reviewed
Jan 20, 2026
zhang2014
reviewed
Jan 20, 2026
Co-authored-by: Winter Zhang <coswde@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
fix: add TrackingPayloadExt trait for ergonomic future tracking
Add an extension trait that provides a more fluent API for tracking futures
with payload. This replaces the verbose static method pattern with a method
call directly on the payload.
Changes:
TrackingPayloadExttrait withtracking()method forTrackingPayload,Arc<TrackingPayload>, andOptionvariantspayload.tracking(future)instead ofThreadTracker::tracking_future_with_payload(future, payload)ThreadTracker::tracking(payload)guard patterns where the payload is immediately used withtracking()InFlightRequestin grpc_service by removing thread guard fieldTests
Type of change
Related Issues
This change is