Skip to content

fix(test): force HTTP/1.1 for sqllogictests client - #19243

Merged
sundy-li merged 2 commits into
databendlabs:mainfrom
sundy-li:http1_only
Jan 13, 2026
Merged

fix(test): force HTTP/1.1 for sqllogictests client#19243
sundy-li merged 2 commits into
databendlabs:mainfrom
sundy-li:http1_only

Conversation

@sundy-li

@sundy-li sundy-li commented Jan 13, 2026

Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • Add .http1_only() to HTTP client configuration in sqllogictests
  • This forces the client to use HTTP/1.1 protocol instead of HTTP/2

Changes

This PR modifies the HTTP client configuration in sqllogictests to force HTTP/1.1 protocol usage by adding .http1_only() method call.

Implementation

  1. Modified tests/sqllogictests/src/client/http_client.rs line 125
  2. Added .http1_only() method call to ClientBuilder
  3. This ensures the client uses HTTP/1.1 protocol for all connections

Tests

  • No Test - Pair with the reviewer to explain why

Type of change

  • Bug fix (non-breaking change which fixes an issue)

This change is Reviewable

@github-actions github-actions Bot added the pr-bugfix this PR patches a bug in codebase label Jan 13, 2026
@sundy-li
sundy-li requested a review from bohutang January 13, 2026 06:38
@sundy-li
sundy-li merged commit 5451e1a into databendlabs:main Jan 13, 2026
254 of 259 checks passed
@sundy-li
sundy-li deleted the http1_only branch January 13, 2026 09:26
bohutang added a commit to bohutang/databend that referenced this pull request Jan 15, 2026
drmingdrmer pushed a commit to drmingdrmer/databend that referenced this pull request Jan 15, 2026
…labs#19264)

* Revert "chore(query): bump ast to 0.2.4 and optimize gRPC configs (databendlabs#19253)"

This reverts commit 84f7338.

* Revert "fix(test): force HTTP/1.1 for sqllogictests client (databendlabs#19243)"

This reverts commit 5451e1a.

* Revert "fix(ci): increase pool_max_idle_per_host (databendlabs#19241)"

This reverts commit f885633.

* Revert "feat(iceberg): bump iceberg-rust to v0.8.0 and add write support (databendlabs#19200)"

This reverts commit 05caa2e.

* fix: update geometry golden file after revert

Update st_geomfromgeohash polygon coordinate order in golden file
to match reverted behavior.

The revert of PR databendlabs#19200 changed the polygon ring starting point
back to the original order, but the unit test golden file was not
updated. This commit fixes the geometry.txt golden file to match
the actual output after the revert.

Related to CI failure in test_unit job.

* fix: update golden files for geometry and cast tests

- geometry.txt: fix Row 1 (u4pruydqqvj0) polygon coordinate order
- geometry.txt: fix internal Output hex representation
- cast.txt: update date parsing error message format to match
  new jiff library error format

The error message format changed from:
  'failed to parse year in date: failed to parse four digit integer as year'
to:
  'failed to parse year in date "X": failed to parse "Y" as year (a four digit integer)'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix this PR patches a bug in codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant