Skip to content

fix(query): NULL constraint checking in column modification - #18855

Merged
sundy-li merged 5 commits into
databendlabs:mainfrom
TCeason:fix-null
Oct 18, 2025
Merged

fix(query): NULL constraint checking in column modification#18855
sundy-li merged 5 commits into
databendlabs:mainfrom
TCeason:fix-null

Conversation

@TCeason

@TCeason TCeason commented Oct 17, 2025

Copy link
Copy Markdown
Collaborator

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

rely on the underlying CAST operations to detect and report NULL constraint violations during execution.

This simplifies the code by eliminating special case handling
while maintaining the same data integrity guarantees.

Fix: #18852

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

rely on the underlying CAST operations to detect and report NULL constraint violations
during execution.

This simplifies the code by eliminating special case handling
while maintaining the same data integrity guarantees.
@github-actions github-actions Bot added the pr-bugfix this PR patches a bug in codebase label Oct 17, 2025
@TCeason
TCeason requested review from b41sh, bohutang and zhyass October 17, 2025 05:22
Comment thread src/query/service/src/interpreters/interpreter_table_modify_column.rs Outdated
@sundy-li
sundy-li merged commit faef998 into databendlabs:main Oct 18, 2025
248 of 253 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix this PR patches a bug in codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ALTER COLUMN NOT NULL Silently Corrupts Data

4 participants