feat(query): Add SecureFilter for Row Access Policies and Stats Privacy - #18623
Merged
Conversation
zhang2014
reviewed
Aug 29, 2025
zhang2014
reviewed
Aug 29, 2025
zhang2014
reviewed
Aug 29, 2025
b41sh
reviewed
Sep 1, 2025
b41sh
approved these changes
Sep 1, 2025
This PR add Plan::SecureFilter, a new operator that automatically applies row access policies defined in table metadata. 1. **Policy Enforcement:** During query binding, if a table has a `row_access_policy`, a `SecureFilter` is automatically inserted directly above the table's `Scan` operator. This ensures the policy is applied early and specifically to that table. 2. **Stats Privacy:** For `SecureFilter`, the optimizer will **hide column-level statistics** (e.g., histograms, NDV). This prevents accidental leakage of sensitive data patterns, even during query planning. 3. **Scoped Application:** `SecureFilter` is marked as non-movable; optimizer rules will *not* push it above joins or merge it into generic filters. This guarantees the policy stays tied to its specific table. 4. **Runtime Filtering:** At execution, `SecureFilter` evaluates its policy expression for each row, filtering out non-compliant rows, similar to a regular `Filter`.
TCeason
marked this pull request as draft
September 1, 2025 08:52
TCeason
force-pushed
the
secure_filter
branch
from
September 1, 2025 09:33
a7b6d7c to
37d13e4
Compare
TCeason
marked this pull request as ready for review
September 1, 2025 09:34
b41sh
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
This PR add Plan::SecureFilter, a new operator that automatically applies row access policies defined in table metadata.
row_access_policy, aSecureFilteris automatically inserted directly above the table'sScanoperator. This ensures the policy is applied early and specifically to that table.SecureFilter, the optimizer will hide column-level statistics (e.g., histograms, NDV). This prevents accidental leakage of sensitive data patterns, even during query planning.SecureFilteris marked as non-movable; optimizer rules will not push it above joins or merge it into generic filters. This guarantees the policy stays tied to its specific table.SecureFilterevaluates its policy expression for each row, filtering out non-compliant rows, similar to a regularFilter.Note:
Need to disable enable_planner_cache. Because stmt maybe same but table meta is different(add or drop a row access policy).
Tests
Type of change
This change is