refactor: add IdempotentKVTxnSender - #18585
Merged
bohutang merged 3 commits intoAug 23, 2025
Merged
Conversation
- make kv txn of `commit_table_meta` idempotent - refactor `update_multi_table_meta` and `create_lock_revision` by using IdempotentKVTxnSender
github-actions
Bot
added
the
pr-refactor
dantengsky
force-pushed
the
feat-IdempotentKVTxnSender
branch
from
August 22, 2025 16:05
e74da9f to
0c76d1a
Compare
dantengsky
force-pushed
the
feat-IdempotentKVTxnSender
branch
from
August 22, 2025 16:11
0c76d1a to
a2ad6e1
Compare
dantengsky
marked this pull request as ready for review
August 23, 2025 03:10
SkyFan2002
approved these changes
Aug 23, 2025
drmingdrmer
approved these changes
Aug 23, 2025
drmingdrmer
left a comment
drmingdrmer
left a comment
Member
There was a problem hiding this comment.
It's a nice refinement and abstraction. Thank you!
@drmingdrmer reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @zhyass)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Add
IdempotentKVTxnSendercommit_table_metaidempotentupdate_multi_table_metaandcreate_lock_revisionby usingIdempotentKVTxnSenderTests
Type of change
This change is