Skip to content

fix: improve error handling in history table - #18504

Merged
bohutang merged 4 commits into
databendlabs:mainfrom
dqhl76:fix-history
Aug 13, 2025
Merged

fix: improve error handling in history table#18504
bohutang merged 4 commits into
databendlabs:mainfrom
dqhl76:fix-history

Conversation

@dqhl76

@dqhl76 dqhl76 commented Aug 8, 2025

Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fix: improve error handling in history table

As a logging service, the history table should avoid exiting on recoverable errors. For issues such as storage being full or temporary network problems with storage, the system should keep retrying until the external service is healthy again.

fix: COPY INTO should with MAX_FILES copy option

If a lot of intermediate logging files stored in stage, the COPY INTO operation should enable a MAX_FILES option to avoid error: Commit limit reached: 15,000 files for 'copy into table'

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions Bot added the pr-refactor this PR changes the code base without new features or bugfix label Aug 8, 2025
@dqhl76 dqhl76 changed the title refactor: reduce history table semaphore acquire attempts refactor: optimize semaphore acquisition for the history table Aug 8, 2025
@dqhl76 dqhl76 changed the title refactor: optimize semaphore acquisition for the history table fix: improve error handling in history table Aug 12, 2025
@github-actions github-actions Bot added the pr-bugfix this PR patches a bug in codebase label Aug 12, 2025
@dqhl76
dqhl76 marked this pull request as ready for review August 13, 2025 01:30
@dqhl76
dqhl76 requested a review from zhang2014 August 13, 2025 01:30
@bohutang
bohutang merged commit 4a23deb into databendlabs:main Aug 13, 2025
244 of 249 checks passed
@dqhl76
dqhl76 deleted the fix-history branch August 27, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix this PR patches a bug in codebase pr-refactor this PR changes the code base without new features or bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants