fix: attach table does not carry the indexes of the original table - #18465
Merged
Conversation
KKould
marked this pull request as ready for review
August 1, 2025 15:45
Member
|
@KKould Do all index types work with this PR? Concerned about specialized indexes like inverted indexes, virtual column indexes, and others. |
Member
Author
In theory, as long as the indexes in TableMeta and the index files are stored on S3, this PR can solve it. Maybe I should add more tests to check the covered indexes. |
dantengsky
approved these changes
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
when attaching a table, the Indexes in the TableMeta will be lost.
after this pr:
Tests
Type of change
This change is