Skip to content

refactor(query): add max_aggregate_restore_worker setting - #18130

Merged
zhang2014 merged 2 commits into
databendlabs:mainfrom
zhang2014:chore/limit_aggregate_restore
Jun 11, 2025
Merged

refactor(query): add max_aggregate_restore_worker setting#18130
zhang2014 merged 2 commits into
databendlabs:mainfrom
zhang2014:chore/limit_aggregate_restore

Conversation

@zhang2014

@zhang2014 zhang2014 commented Jun 10, 2025

Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor(query): add the max_aggregate_restore_worker configuration to limit the number of restore threads, with a default value of 16. current ci can cover/verify this change.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@zhang2014
zhang2014 requested a review from sundy-li June 10, 2025 16:06
@zhang2014 zhang2014 added the ci-benchmark Benchmark: run all test label Jun 10, 2025
@github-actions github-actions Bot added the pr-refactor this PR changes the code base without new features or bugfix label Jun 10, 2025
@sundy-li

Copy link
Copy Markdown
Member

please fix the tests.

@zhang2014
zhang2014 merged commit 6d60e04 into databendlabs:main Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-benchmark Benchmark: run all test pr-refactor this PR changes the code base without new features or bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants