fix(query): system.columns will return empty result when where database in (y,x) - #18063
Merged
Conversation
b41sh
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Problem
This PR fixes system.columns returning incomplete results when users have partial grants and queries include multi-database conditions like WHERE database IN (...).
The root cause was the old filtering mechanism, find_eq_filter, failing to correctly process such complex filters.
Solution
By replacing it with find_eq_or_filter, the system now accurately identifies and displays all accessible metadata, significantly improving system.columns reliability for users with granular access rights.
Tests
Type of change
This change is