Skip to content

fix(query): change default format_null_as_str to false - #18026

Merged
bohutang merged 1 commit into
databendlabs:mainfrom
everpcpc:fix-null
May 28, 2025
Merged

fix(query): change default format_null_as_str to false#18026
bohutang merged 1 commit into
databendlabs:mainfrom
everpcpc:fix-null

Conversation

@everpcpc

@everpcpc everpcpc commented May 28, 2025

Copy link
Copy Markdown
Member

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

We have already support json null in all drivers.
Changing this default to false, then we could correctly handle Nullable(String) with 'NULL' in response.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions Bot added the pr-bugfix this PR patches a bug in codebase label May 28, 2025
@everpcpc
everpcpc requested a review from youngsofun May 28, 2025 10:17
@bohutang
bohutang merged commit a010d96 into databendlabs:main May 28, 2025
@everpcpc
everpcpc deleted the fix-null branch May 28, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix this PR patches a bug in codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants