Skip to content

fix(binder): nondeterministic_update should accept not nullable inputs - #17874

Merged
forsaken628 merged 3 commits into
databendlabs:mainfrom
forsaken628:fix-17573
May 2, 2025
Merged

fix(binder): nondeterministic_update should accept not nullable inputs#17874
forsaken628 merged 3 commits into
databendlabs:mainfrom
forsaken628:fix-17573

Conversation

@forsaken628

@forsaken628 forsaken628 commented Apr 30, 2025

Copy link
Copy Markdown
Collaborator

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

This pr adds a cast after any aggregation to ensure that the data type after aggregation is the same as the original data type.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

Signed-off-by: coldWater <forsaken628@gmail.com>
@github-actions github-actions Bot added the pr-bugfix this PR patches a bug in codebase label Apr 30, 2025
@forsaken628 forsaken628 changed the title fix(binder): nondeterministic_update should accept not null inputs fix(binder): nondeterministic_update should accept not nullable inputs Apr 30, 2025
Signed-off-by: coldWater <forsaken628@gmail.com>
@forsaken628
forsaken628 marked this pull request as ready for review May 2, 2025 06:53
@forsaken628
forsaken628 requested a review from sundy-li May 2, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix this PR patches a bug in codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: update from ConstantTableScan panic

2 participants