Skip to content

fix: string Scalar should be escaped in sql_display - #17854

Merged
sundy-li merged 4 commits into
databendlabs:mainfrom
youngsofun:escape
Apr 26, 2025
Merged

fix: string Scalar should be escaped in sql_display#17854
sundy-li merged 4 commits into
databendlabs:mainfrom
youngsofun:escape

Conversation

@youngsofun

@youngsofun youngsofun commented Apr 25, 2025

Copy link
Copy Markdown
Member

to be able to parse again.

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

expr may be serialized to string, and be parse again later.
so string scalar in expr have to be escaped.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions Bot added the pr-bugfix this PR patches a bug in codebase label Apr 25, 2025
@youngsofun youngsofun changed the title fix: string Scalar should escape when displayed. fix: string Scalar should escape in sql_display Apr 26, 2025
@youngsofun youngsofun changed the title fix: string Scalar should escape in sql_display fix: string Scalar should be escaped in sql_display Apr 26, 2025
@sundy-li
sundy-li merged commit 7f7c735 into databendlabs:main Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix this PR patches a bug in codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants