build(deps): Bump actions/setup-go from 6.5.0 to 7.0.0 - #1390
Conversation
532c591 to
467978c
Compare
Dependency Review —
|
| Advisory | GHSA-8r6m-32jq-jx6q — fast-xml-parser repeated-DOCTYPE entity-expansion limit reset (billion-laughs DoS) |
| Affected | >=5.9.3 <5.10.1 — patched in 5.10.1 |
| Path | setup-go → @actions/cache@6.2.0 → @azure/storage-blob@12.32.0 → @azure/core-xml@1.5.1 → fast-xml-parser@5.9.3 |
| Introduced here? | Yes. v6.5.0 bundles fast-xml-parser@5.8.0, which is below the affected floor. Verified with npm audit --omit=dev at both tags. |
| Fix available? | No. The advisory was published 2026-07-21, five days after v7.0.0 shipped, and setup-go freezes 5.9.3 into its committed dist/. Only an upstream setup-go rebuild (v7.0.1) resolves it. |
Real-world exploitability in our CI is low: the parsed XML comes from the Azure Blob endpoints behind GitHub's Actions cache service, so exploitation requires MITM or a compromised GitHub cache backend, and the impact is a CI job hang/OOM — not RCE or secret disclosure. Additionally, in build.yml, check-generated.yml, e2e.yml and govulncheck.yml, setup-go runs before actions/checkout, so caching silently no-ops there (##[warning]Restore cache failed: Dependencies file is not found) and the affected code path is never reached. Only lint.yml, tests.yml and release.yml exercise it.
Note that Dependabot's github-actions ecosystem does not scan transitive npm advisories inside an action's bundled dist/ — nothing would have flagged this automatically.
Recommendation
Since v7.0.0 is functionally identical to v6.5.0 for our usage, there is no benefit to merging now and a small net-negative on the dependency-security axis. Suggest holding ~1–2 weeks for a v7.0.1 that refreshes fast-xml-parser to >=5.10.1, then merging. Merging now is also defensible given the low exploitability — flagging for a human call rather than auto-merging.
On the red govulncheck check — unrelated to this PR
The failure is GO-2026-6061 in google.golang.org/grpc@v1.82.0 (xDS RBAC engine / HTTP/2 server transport), not a stdlib crypto/tls issue, and not something a rebase fixes — v1.6-dev and this PR head both already carry go 1.26.5, and both still pin grpc v1.82.0. It reproduces identically on the base branch and is call-reachable from cmd/priv_val_server/main.go, abci/server/grpc_server.go and abci/client/grpc_client.go.
#1392 (grpc 1.82.0 → 1.82.1) is the fix and should be merged first — it unblocks govulncheck for this PR and every other open PR.
Pre-existing issues spotted nearby (not blocking, worth a follow-up)
.github/actions/bls/action.ymlpinsactions/setup-go@v2— an ancient, unmaintained major. Dependabot never bumps it because.github/dependabot.ymlonly registersdirectory: "/"for thegithub-actionsecosystem, which does not cover composite actions under.github/actions/. It also pins Go1.26.4(inconsistent with1.26.5elsewhere) and uses the disabled::set-outputcommand.- Moving
setup-goafteractions/checkoutinbuild.yml/check-generated.yml/e2e.yml/govulncheck.ymlwould make module caching actually work — a free CI speedup. build.yml,e2e.yml,lint.yml,tests.ymland especiallyrelease.ymlhave nopermissions:block and fall back to the repo default; an explicitcontents: read(plus a narrow grant for GoReleaser inrelease.yml) would bound the blast radius of any compromised action.
🤖 Co-authored by Claudius the Magnificent AI Agent
Update —
|
|
@dependabot rebase |
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 6.5.0 to 7.0.0. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v6.5.0...v7.0.0) --- updated-dependencies: - dependency-name: actions/setup-go dependency-version: 7.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
467978c to
3846bb0
Compare
Bumps actions/setup-go from 6.5.0 to 7.0.0.
Release notes
Sourced from actions/setup-go's releases.
Commits
b7ad1dachore(deps): bump@actions/cacheto 6.2.0 (#771)0778a10Migrate to ESM and upgrade dependencies (#763)