fix(autopatch): prevent chi route-context reuse in internal requests#1049
Merged
Conversation
PR #1019 propagated the incoming request context to autopatch's internal GET/PUT sub-requests. With the chi adapter that also carried chi's matched route state (chi.RouteCtxKey), which chi reuses instead of routing again, so the bodyless internal GET was routed back into the generated PATCH handler, recursing and panicking on io.ReadAll(nil). Add an optional internalContextSanitizer hook: autopatch asks the adapter to sanitize the context used for internal sub-requests, staying router-agnostic (no chi import). The chi adapter implements it by shadowing chi.RouteCtxKey so internal requests route fresh, while preserving all other context values, deadlines, and cancellation. Other adapters are unaffected. Includes a chi-backed regression test that panics on io.ReadAll(nil) without the fix.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1049 +/- ##
=======================================
Coverage 93.14% 93.14%
=======================================
Files 23 23
Lines 4901 4905 +4
=======================================
+ Hits 4565 4569 +4
Misses 272 272
Partials 64 64 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1019 propagated the incoming request context to autopatch's internal GET/PUT sub-requests. With the chi adapter that also carried chi's matched route state (chi.RouteCtxKey), which chi reuses instead of routing again, so the bodyless internal GET was routed back into the generated PATCH handler, recursing and panicking on io.ReadAll(nil).
Add an optional internalContextSanitizer hook: autopatch asks the adapter to sanitize the context used for internal sub-requests, staying router-agnostic (no chi import). The chi adapter implements it by shadowing chi.RouteCtxKey so internal requests route fresh, while preserving all other context values, deadlines, and cancellation. Other adapters are unaffected.
Includes a chi-backed regression test that panics on io.ReadAll(nil) without the fix.