Add encoding.TextUnmarshaler support for slice query parameters#1021
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1021 +/- ##
==========================================
- Coverage 93.07% 93.05% -0.03%
==========================================
Files 23 23
Lines 4781 4868 +87
==========================================
+ Hits 4450 4530 +80
- Misses 271 274 +3
- Partials 60 64 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Added test case to simulate an UnmarshalError in `parseSliceInto()` - Added test case to simulate returning ErrUnparsable from `parseSliceInto()`
wolveix
approved these changes
May 28, 2026
Collaborator
|
Awesome work, thanks @B94715! |
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I must apologise, I accidentally pushed a PR (#1020) mistakenly commenting out tests that I did not own and didn't catch this until it was too late. I closed the PR immediately to rectify the issue but wasn't aware that GitHub automatically locks closed PRs when
--force-with-leaseis applied to agit push. The original PR was thus--
This directly addresses #488 and is an alternative to #998.
parseSliceInto()was missing the encoding.TextUnmarshaler fallback thatparseInto()already has. This aims to address that.