Skip to content

September improvements by @backslash47#143

Closed
danfickle wants to merge 10 commits into
danfickle:open-dev-v1from
backslash47:open-dev-v1
Closed

September improvements by @backslash47#143
danfickle wants to merge 10 commits into
danfickle:open-dev-v1from
backslash47:open-dev-v1

Conversation

@danfickle

Copy link
Copy Markdown
Owner

Thanks for the awesome work @backslash47

danfickle added a commit that referenced this pull request Oct 18, 2017
@danfickle

Copy link
Copy Markdown
Owner Author

Hi @backslash47

The symbol showTextWithPositioning can not be found on the PDF-BOX content stream. I guess this is using a private version of PDF-BOX? If you could upload the code somewhere, even as a gist, or point me to it, I could file an issue with PDF-BOX to get this method included.

Thanks,
Daniel.

danfickle added a commit that referenced this pull request Oct 19, 2017
…r images.

This should allow percentage values in max-height and max-width for
images. Fix suggested in #143 Thanks @backslash47
@backslash47

backslash47 commented Oct 19, 2017

Copy link
Copy Markdown
Contributor

Hello,
I have it here: backslash47/pdfbox@3c52829

I did not have much time to work it into PDFBOX repo. If you can propose it to pdfbox maintainers, it would be great.

HttpStreamFactory httpStreamFactory,
OutputStream os, FSUriResolver resolver, FSCache cache, SVGDrawer svgImpl,
PageDimensions pageSize, float pdfVersion, String replacementText, boolean testMode, FSObjectDrawerFactory objectDrawerFactory) {
PageDimensions pageSize, float pdfVersion, String pdfAConformance, byte[] colorProfile, String replacementText, boolean testMode, FSObjectDrawerFactory objectDrawerFactory) {

@schmitch schmitch Oct 24, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it is a good idea to pass the pdfAConformance as a string.

They actually barley change over the years.

@danfickle

Copy link
Copy Markdown
Owner Author

We're now waiting on PDFBOX-3992 for the show text with positioning operator (TJ).

@danfickle danfickle mentioned this pull request Jan 16, 2018
23 tasks
danfickle added a commit that referenced this pull request Jul 3, 2018
cherry-picked commit from pr #143: bold and italic emulation
danfickle added a commit that referenced this pull request Jul 14, 2018
Cherry-pick from PR #143: pdf/a support
danfickle added a commit that referenced this pull request Jul 28, 2018
danfickle added a commit that referenced this pull request Aug 3, 2018
Includes support for min/max height/width properties and test cases.
Limitations:
+ Not implemented for replaced elements such as images/MathML, etc.
+ Not taken into account during the table layout algorithm.
@danfickle

Copy link
Copy Markdown
Owner Author

Should be finished with this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants