feat(share): sharing-visibility foundation (PR 1) - #6343
Draft
tsahimatsliah wants to merge 2 commits into
Draft
Conversation
Reusable ShareActions primitive (icon/inline variants, desktop popover + mobile native share) plus the initiative's flags and a flag-gated core copy-icon swap. - add ShareActions + Storybook story, useSharingVisibility gate - add feature_sharing_visibility (master kill-switch) and share_copy_icon - gate LinkIcon->CopyIcon swap behind share_copy_icon (default off == main) in ShareMobile, ActionButtons.v2, BriefPostHeaderActions - add share-surface Origin values Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
🧭 Task context (auto-maintained by /fresh)
Current focus: PR 1 (Foundation) is complete. Next up is PR 2 (feed-card copy-icon + hover share-out), Storybook-first. Decisions (and why):
Key files:
Done:
Next:
Gotchas:
To continue this task in a fresh chat: check out |
This was referenced Jul 22, 2026
tsahimatsliah
added a commit
that referenced
this pull request
Jul 27, 2026
Clicking the profile control opened a network popover — a second decision before anything useful happened. It now copies straight away and confirms twice: the glyph flips to a green check for a second (VIcon in text-status-success, the same check the product uses elsewhere) and a toast names what landed on the clipboard. - ProfileShareButton drops ShareActions and drives useShareOrCopyLink directly, so it keeps the dly.to shortening, the ShareProfile referral campaign and the ShareProfile log event with its provider. - Mobile is unchanged: where the platform offers a native share sheet a tap still opens it, and the check/toast only fire on the copy path. - Labels follow the behaviour: "Copy link to your profile" / "Copy link to @user's profile", replacing the old "Share …". - useShareOrCopyLink takes an optional copyMessage so the toast can name the profile instead of the generic "Copied link to clipboard". ShareActions itself is untouched and still owned by PR 1 (#6343) for the other surfaces in the initiative. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
tsahimatsliah
added a commit
that referenced
this pull request
Jul 28, 2026
Review pass: this PR was reaching into files PR 1 (#6343) owns, even though none of them are needed for the profile control. Restored to the base branch, unchanged by this PR: - ShareActions.tsx — the profile control drives useShareOrCopyLink directly, so it has no reason to touch the primitive's glyph. - ShareMobile / ActionButtons.v2 / BriefPostHeaderActions and useShareCopyIcon — the share_copy_icon experiment is PR 1's call about a different set of surfaces, not this PR's to unwind. - useSharingVisibility and the sharing_visibility flag — this PR stops consuming the initiative-wide kill-switch, but deleting infrastructure later surfaces may still want belongs in PR 1. - ShareActions.stories.tsx — reverted the decorator refactor. The Storybook review page documents this PR's control instead of PR 1's primitive: the variant/size grid now renders ProfileShareButton with the two combinations actually used. Net diff is 13 files, all profile-share. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Foundation for the sharing-visibility initiative — a reusable share affordance + flags. Behind flags;
share_copy_icondefault off means no user-visible change vs main.Part of the multi-PR sharing-visibility initiative (Storybook-first, one PR per surface). Full plan tracked separately.
Highlights
ShareActionsprimitive (icon/inline; desktop popover, mobile native share) + Storybook storyfeature_sharing_visibilitymaster kill-switch +useSharingVisibilitygateshare_copy_icon(default off) viauseShareCopyIconOriginvalues🤖 Generated with Claude Code
Preview domain
https://claude-website-sharing-visibilit.preview.app.daily.dev