Skip to content

Improvement: extract interface#9

Merged
d2phap merged 2 commits into
d2phap:mainfrom
samba2:feature/separate-interface
Dec 10, 2022
Merged

Improvement: extract interface#9
d2phap merged 2 commits into
d2phap:mainfrom
samba2:feature/separate-interface

Conversation

@samba2

@samba2 samba2 commented Dec 7, 2022

Copy link
Copy Markdown

Extracted the FileSystemWatcherEx API into separate interface IFileSystemWatcherEx. Mainly to simplify testing via e.g. Moq or own alternative implementations.

To clarify: should the documentation also remain in FileSystemWatcherEx (duplication) or should we just have it in the interface and hance delete the comments from FileSystemWatcherEx ?

@samba2

samba2 commented Dec 7, 2022

Copy link
Copy Markdown
Author

additional remark: this was an automated refactoring.

@samba2

samba2 commented Dec 7, 2022

Copy link
Copy Markdown
Author

just some additional thoughts:

  • maybe we should make the interface slimer. Really just focus on behavior
  • we probably should also use the interface in the demo app and in the unit tests, so somthing like IFileSystemWatcherEx fw = new FileSystemWatcherEx(...)

@d2phap d2phap left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @samba2 !

@d2phap
d2phap merged commit e8dae70 into d2phap:main Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants