Optimize Pre-Phase Unrolling in Meta-Automaton - #303
Merged
Conversation
Nikil-Shyamsunder
force-pushed
the
pre-phase-unrolling
branch
2 times, most recently
from
August 16, 2026 18:40
4efb6b7 to
1296864
Compare
Nikil-Shyamsunder
force-pushed
the
pre-phase-unrolling
branch
from
August 16, 2026 18:54
1296864 to
5f71c76
Compare
Nikil-Shyamsunder
marked this pull request as ready for review
August 16, 2026 20:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously, if given a finite pre-phase or set of possible pre-phase lengths, we were unrolling it all the way even when we didn't need to. This prevents that from happening. The details of when vs. when we don't need to unroll are in the automata-paper repo.
also make the examples better looking. I reccommend looking at steady_state_varying_pre_and_post_lengths
This has transaction "A" with a pre-phase that can take 1 or 2 cycles, and post phase of 1 cycle. And "S" with a pre-phase of 1 cycle and post phase of 2 cycles. This case shows how we enumerate fork vs. continue for certain numbers of cycles sometimes and not others to keep the automata small, and how bank rotation works in some pretty complicated cases.