Crypto deprecations in node 10

[kallaspriit]

Getting deprecation warnings when used on node 10.

[DEP0091] DeprecationWarning: crypto.DEFAULT_ENCODING is deprecated.
[DEP0010] DeprecationWarning: crypto.createCredentials is deprecated. Use tls.createSecureContext instead.
[DEP0011] DeprecationWarning: crypto.Credentials is deprecated. Use tls.SecureContext instead.

[kallaspriit]

Any progress/plans on this? Would a PR get merged?

[cscott]

A PR would be happily merged. There are similar cases where we avoid probing deprecated properties for certain node versions, you should be able to copy that.

…

On Thu, Aug 9, 2018, 7:14 AM Priit Kallas ***@***.***> wrote: Any progress/plans on this? Would a PR get merged? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJhsNBUenv_69lggwSWrpPyeV7xyUcUks5uPBmQgaJpZM4VLXHg> .

[kallaspriit]

I made a simple pull request but not sure if it helps as I changed the file directly not the generator.

Anyway after testing this I discovered that the actual warnings are not coming from Your library but rather from a simple import * as crypto from "crypto";, probably as it enumerates everything without even using the deprecated properties. Changing to import exactly what I need import { createHash } from "crypto"; etc fixed it.

For anyone trying to figure out where the deprecation warnings are coming from, running node with --trace-deprecation helps.

For example with Jest running node --trace-deprecation node_modules\jest\bin\jest gave me:

(node:20804) [DEP0091] DeprecationWarning: crypto.DEFAULT_ENCODING is deprecated.
    at Object.<anonymous>.__importStar (C:\xxx\index.ts:6:94)
    ...