Skip to content

Fix #14783 / #14784 FN unusedVariable with templated type (default constructor, regression) #8574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrchr-github wants to merge 3 commits into
base: main
Choose a base branch
from
+19 −4
Open

Fix #14783 / #14784 FN unusedVariable with templated type (default constructor, regression) #8574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
585b9a0
Fix #14783 FN unusedVariable with templated type (default constructo…
web-flow May 25, 2026
e95639c
Comment
web-flow May 25, 2026
325c86d
Update testunusedvar.cpp
chrchr-github May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions lib/checkunusedvar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1160,10 +1160,6 @@ void CheckUnusedVar::checkFunctionVariableUsage_iterateScopes(const Scope* const
variables.read(tok2->varId(), tok);
}
}
} else if (tok->variable() && tok->variable()->isClass() && tok->variable()->type() &&
(tok->variable()->type()->needInitialization == Type::NeedInitialization::False) &&
tok->strAt(1) == ";") {
variables.write(tok->varId(), tok);
}
}
}
Expand Down
19 changes: 19 additions & 0 deletions test/testunusedvar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7070,6 +7070,24 @@ class TestUnusedVar : public TestFixture {
" S<0> s;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:6:10]: (style) Unused variable: s [unusedVariable]\n", errout_str());

functionVariableUsage("template <typename T>\n" // #14783
"struct A {\n"
" A() = default;\n"
"};\n"
"void f() {\n"
" A<int> a;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:6:12]: (style) Unused variable: a [unusedVariable]\n", errout_str());

functionVariableUsage("template <typename T>\n" // #14784
"struct A {\n"
" A() {}\n"
"};\n"
"void f() {\n"
" A<int> a;\n"
"}\n");
ASSERT_EQUALS("[test.cpp:6:12]: (style) Unused variable: a [unusedVariable]\n", errout_str());
}

void localvarFuncPtr() {
Expand Down Expand Up @@ -7158,6 +7176,7 @@ class TestUnusedVar : public TestFixture {
"void f() {\n"
" Y y;\n"
"}"); // #4695
ASSERT_EQUALS("[test.cpp:6:7]: (style) Unused variable: y [unusedVariable]\n", errout_str());
}

void crash3() {
Expand Down
Loading