preview: mirror fork PR #7695#7704
Closed
github-actions[bot] wants to merge 2 commits into
Closed
Conversation
TWAP orders are always settled against the production CoW Protocol settlement contract, but the spender override was using the environment-aware COW_PROTOCOL_VAULT_RELAYER_ADDRESS from @cowprotocol/common-utils, which resolves to the staging vault relayer on the barn backend env. As a result, allowances granted on the barn-deployed app targeted the staging relayer and TWAP orders were unfillable on Safe due to insufficient allowance against the prod relayer. Add a prod-only re-export, COW_PROTOCOL_VAULT_RELAYER_ADDRESS_PROD, in @cowprotocol/common-utils and use it for the TWAP spender override, so TWAP allowances always target the production relayer regardless of the current environment. Closes #7690
Addresses @kernelwhisperer's feedback on #7695 — rename the SDK import alias to an internal underscore-prefixed name so COW_PROTOCOL_VAULT_RELAYER_ADDRESS_PROD is the only PROD-named export. The cast to AddressPerChain is still needed because the SDK's type differs from AddressPerChain.
github-actions
Bot
added
the
DONT_MERGE
Deploying explorer-dev with
|
| Latest commit: |
e81f214
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://374988ff.explorer-dev-dxz.pages.dev |
| Branch Preview URL: | https://cf-preview-pr-7695.explorer-dev-dxz.pages.dev |
6 tasks
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Deploying swap-dev with
|
| Latest commit: |
e81f214
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8a0c746e.swap-dev-5u6.pages.dev |
| Branch Preview URL: | https://cf-preview-pr-7695.swap-dev-5u6.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mirrors fork PR #7695 for Cloudflare Pages preview builds.
Source PR: #7695
Source fork branch:
tenderdeve/cowswap:fix/7690-twap-allowance-prod-relayerMirrored SHA:
e81f2148821cDo not merge this PR. Close the source PR to clean up this mirror.