fix(github): evaluate watch paths against push diff#10938
Open
wottpal wants to merge 1 commit into
Open
Conversation
wottpal
marked this pull request as ready for review
July 15, 2026 07:26
Author
|
Addendum: Did a full manual testing suite now (successfully) ✅ – Obviously, with the help of an LLM ( Manual testingLocal setup
Reproducing the false deployment on the parent commit
Verifying this PR with the same payload
Positive control: a real net change still deploys
Compare API failure fallback
Additional checks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
beforeandafterSHAs instead of unioning every pushed commit's file arrays.Issues
Category
Preview
Not applicable; this changes backend webhook filtering behavior and adds regression tests.
AI Assistance
If AI was used:
Testing
vendor/bin/pest tests/Unit/GithubPushChangedFilesTest.php— 4 tests passed, 5 assertions.vendor/bin/pint app/Http/Controllers/Webhook/Github.php bootstrap/helpers/github.php tests/Unit/GithubPushChangedFilesTest.php— passed.php -lfor all three changed PHP files — passed.git diff --check— passed.tests/Feature/GithubWebhookTest.phpwas attempted in the standalone checkout; three manual-webhook cases passed, while the normal-webhook case could not boot because the in-memory SQLite test database lacked theinstance_settingstable. The failure occurs before the changed push-filtering path.Contributor Agreement
Important