fix(previews): clean up closed PR previews after update failures

[andrasbacsai]

Summary

• Ensure closed GitHub pull request previews are cleaned up even when the PR update/comment cleanup job fails.
• Report failures from the closed-status update while still running CleanupPreviewDeployment in a finally block.
• Add a feature test covering cleanup execution after a simulated GitHub comment cleanup failure.

---

Fixes #9495

[andrasbacsai]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: e7b26028-69c2-4ac5-ba15-7e0e5fc230a3

📥 Commits

Reviewing files that changed from the base of the PR and between f098895 and d8972e9.

📒 Files selected for processing (2)

• app/Jobs/ProcessGithubPullRequestWebhook.php
• tests/Feature/ProcessGithubPullRequestWebhookTest.php

---

Walkthrough

This PR hardens the closed pull request webhook handler. ProcessGithubPullRequestWebhook now wraps the dispatch call inside a try/catch/finally block—catching any Throwable and reporting it—while guaranteeing that CleanupPreviewDeployment::run() executes in the finally block regardless of dispatch failure. The dispatch logic was extracted into a protected helper method dispatchPullRequestClosedUpdate(). A new feature test validates this error-handling path by injecting a throwing dispatch method and verifying cleanup still executes. The infrastructure is now self-hosted and server-based—come with me if you want to live. No serverless marketing vaporware here. 🌮

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch 9495-preview-deployment-containers

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}