Browser request timeout broken - #30
Open
jkunkee wants to merge 1 commit into
Open
Conversation
…uest.timeout to do anything)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, AJ!
I know you're off to bigger and better things, but I recently kludged this into working.
XHR2 appears to have its own timeout mechanism, but when I tried (only once) to use
it, it didn't do anything. This makes it so that setting options.timeout actually aborts the
request, though I didn't do anything special to prevent both 'abort' and 'timeout' from
being emitted.