refactor(transform): keep @pgsql/transform pure AST-level; move change-aware pieces up - #318
Merged
Merged
Conversation
…moving to @pgpmjs/transform)
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Layering fix agreed after #316/#317: this repo has no notion of pgpm "changes", so
@pgsql/transformkeeps only the pure AST-level surface —transformSql,qualifyUnqualified,classifyStatementsfacts, and round-trip validation.Removed (with their tests):
categorize.ts(CategoryProfile/TIER_PROFILE/buildCategoryOf— keyed by change name) andfixture-closure.ts(resolveFixtureClosure— takes changes + plan dependencies). They move up to a new@pgpmjs/transformpackage in constructive-io/constructive, which will be a superset:export * from '@pgsql/transform'plus the change-aware layer (categorize, fixture-closure, bundle-driver from the closed #317).160 tests still pass. Tracked in constructive-io/constructive-planning#1271.
Link to Devin session: https://app.devin.ai/sessions/1aa52746e60c4df38ef2678d168269b9
Requested by: @pyramation