fix(export): change field.type from text to jsonb in META_TABLE_CONFIG#1233
Merged
Conversation
metaschema_public.field.type is now a jsonb column (FieldType objects). The text coercion hint caused csv-to-pg to call String() on JS objects, producing [object Object] in generated SQL INSERT statements.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metaschema_public.field.typeis now ajsonbcolumn (FieldType objects like{"name":"uuid"}). TheMETA_TABLE_CONFIGin@pgpmjs/exportstill hadtype: 'text'for this column, which caused csv-to-pg's text coercion handler to callString()on JS objects — producing[object Object]in generated SQL INSERT statements.One-line fix:
type: 'text'→type: 'jsonb'in the field table config.Root cause: The old patch (
patches/@pgpmjs__export@0.19.0.patch) in constructive-db applied this fix, but it was never upstreamed into the source. When@pgpmjs/exportwas bumped to0.19.1, the patch became stale and was removed, exposing the bug.Review & Testing Checklist for Human
generateCI job should produce valid JSON strings instead of[object Object]for field type valuesmigrate/fieldSQL has proper JSON like'{"name":"uuid"}'instead of'[object Object]'Notes
Blocks constructive-db#1405 — once this is published, that PR's CI should pass.
Link to Devin session: https://app.devin.ai/sessions/f9a05fd1f300470e8f6a398ebb59ecb4
Requested by: @pyramation