allowing tool-requires negated or - #19780
Merged
czoido merged 8 commits intoMar 25, 2026
Merged
Conversation
franramirez688
approved these changes
Mar 23, 2026
czoido
reviewed
Mar 24, 2026
Comment on lines
+236
to
+238
| mold/1.0 | ||
| !zlib*:cmake/1.0 | ||
| !mold*:cmake/1.0 |
Contributor
There was a problem hiding this comment.
The fact that changing the order will make the test fail:
!zlib*:cmake/1.0
mold/1.0
!mold*:cmake/1.0
makes me wonder if we want to change the way this syntax is processed or maybe we should reconsider using the original one which feels more explicit: !(zlib*|mold*):cmake/1.0
franramirez688
approved these changes
Mar 24, 2026
czoido
approved these changes
Mar 25, 2026
AbrilRBS
approved these changes
Mar 25, 2026
This was referenced Mar 25, 2026
memsharded
added a commit
to memsharded/conan
that referenced
this pull request
Apr 22, 2026
* allowing tool-requires negated or * fix * new proposal * review * format --------- Co-authored-by: Francisco Ramírez <franchuti688@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Feature: Allow negated OR patterns
!(<pattern1>|<pattern2>|...)in profile[tool_requires]for breaking cycles in build context.Docs: conan-io/docs#4403
Alternative to #19387
Closes #17474
Close #19773