Fix potential None and PackageType comparison when deducing cpp_info - #19494
Merged
ErniGH merged 5 commits intoJan 22, 2026
Merged
Conversation
AbrilRBS
commented
Jan 21, 2026
AbrilRBS
marked this pull request as draft
January 21, 2026 14:23
AbrilRBS
marked this pull request as ready for review
January 21, 2026 14:26
memsharded
approved these changes
Jan 21, 2026
ErniGH
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Avoid potential
NoneandPackageTypecomparison when deducingcpp_info.Docs: Omit
Got a question from @ErniGH about a failing code they were getting in another project, traced this to a case where:
deduce_full_cpp_info()- This tests uses CMakeConfigDeps, but they were calling it directly from within hook checkstypeof one of them.The overloaded comparison for
PackageTypecan't initialize an other value ofNoneand breaks.Maybe a better approach would be to re-think the check just above for header-only, as it makes little sense to me why this would only trigger after 2 components (because said branch is not taken)