[cyclonedx][bugfix] Omitting test_requires - #18873
Merged
Merged
Conversation
1 task
memsharded
commented
Sep 3, 2025
| nodes = [node for node in graph.nodes if (node.context == "host" or add_build) and (not node.test or add_tests)] | ||
| name_default += f"/{graph.root.ref.version}" if getattr(graph.root.ref, "version", False) else "" | ||
|
|
||
| def should_add_node(n): |
Member
Author
There was a problem hiding this comment.
This is the fix, making sure no node is added to dependsOn that is not checked against this condition.
ErniGH
reviewed
Sep 4, 2025
AbrilRBS
approved these changes
Sep 4, 2025
ErniGH
approved these changes
Sep 4, 2025
franramirez688
changed the title
test_requires
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Omit the
test_requireswhencyclonedx(..., add_test=False))in all cases, includingconan installconsumption.Docs: Omit
Close #18870
Sorry for the extra formatting @ErniGH... 😅 I'll mark the exact fix in a comment