PremakeDeps: added traits management support - #18663
Merged
Merged
Conversation
AbrilRBS
reviewed
Jul 18, 2025
memsharded
reviewed
Jul 20, 2025
memsharded
left a comment
memsharded
left a comment
Member
There was a problem hiding this comment.
I don't see tests that check that defines are not propagated under certain conditions.
memsharded
approved these changes
Jul 21, 2025
Member
|
For now this looks good. Once we investigate in #18673, we might come back to update these filters |
AbrilRBS
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: PremakeDeps will now correctly propagate libraries, headers and binaries depending on the requirement traits.
Docs: omit