cmake: add support for cli_args in install() - #14397
Merged
memsharded merged 1 commit intoJul 30, 2023
Merged
Conversation
memsharded
reviewed
Jul 30, 2023
memsharded
left a comment
memsharded
left a comment
Member
There was a problem hiding this comment.
Looking good, just one minor comment about the warning
| if cli_args: | ||
| if "--install" in cli_args: | ||
| raise ConanException("Do not pass '--install' argument to 'install()'") | ||
| if "--strip" in cli_args: |
Member
There was a problem hiding this comment.
I am not sure about this warning, it should either be normally allowed or raise an error, but from my experience this kind of warning doesn't help much as it pass unnoticed, or it annoys the user that actually wants to do that.
Contributor
Author
There was a problem hiding this comment.
Sure :) The rationale for that warning was that I wanted the user to be aware of that feature. It wasn't even documented, and I got to know about it myself while reading the code.
I removed the warning. The configuration mentioning in the docs is added separately at conan-io/docs#3314
This commit fixes conan-io#14235
mkmkme
force-pushed
the
mkmkme/cmake-install-args
branch
from
July 30, 2023 11:51
1dbcd35 to
f683d91
Compare
memsharded
approved these changes
Jul 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes #14235
Changelog: Feature: Add
cli_argsargument forCMake.install().Docs: conan-io/docs#3314
developbranch, documenting this one.