Skip to content

Split build & compilation verbosity control into two confs - #13729

Merged
AbrilRBS merged 20 commits into
conan-io:release/2.0from
AbrilRBS:rr/meson-verbose
May 31, 2023
Merged

Split build & compilation verbosity control into two confs#13729
AbrilRBS merged 20 commits into
conan-io:release/2.0from
AbrilRBS:rr/meson-verbose

Conversation

@AbrilRBS

@AbrilRBS AbrilRBS commented Apr 19, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Changelog: Feature: Split build & compilation verbosity control to two confs.
Docs: conan-io/docs#3277

Adds verbosity confs for:

tool name build:verbosity compilation:verbosity
cmake ✔️ ✔️
xcodebuild* ✔️ ✔️
msbuild ✔️ -
meson ✔️ ✔️
  • xcodebuild is not clear to me nor to @czoido what verbosity controls, so both confs activate it! Probably want to change it

Closes #13703
Closes #12239

memsharded
memsharded reviewed Apr 20, 2023
View reviewed changes
Comment thread conan/tools/cmake/cmake.py Outdated
@AbrilRBS
AbrilRBS marked this pull request as ready for review April 26, 2023 09:02
@memsharded memsharded added this to the 2.0.5 milestone May 4, 2023
@AbrilRBS
AbrilRBS requested a review from memsharded May 5, 2023 13:25
memsharded
memsharded approved these changes May 5, 2023
View reviewed changes

@memsharded memsharded left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the broken test

@AbrilRBS

AbrilRBS commented May 6, 2023

Copy link
Copy Markdown
Member Author

Can't repro locally, I ran those tests before commiting. Weird. 🤔

SpaceIm
SpaceIm reviewed May 7, 2023
View reviewed changes
Comment thread conan/tools/cmake/cmake.py Outdated
@memsharded memsharded modified the milestones: 2.0.5, 2.0.6 May 10, 2023
@CLAassistant

CLAassistant commented May 18, 2023 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@AbrilRBS AbrilRBS changed the title [wip] Add meson and cmake verbosity levels [wip] Split build & compilation verbosity control to two confs May 22, 2023
@memsharded memsharded modified the milestones: 2.0.6, 2.0.7 May 24, 2023
@AbrilRBS AbrilRBS changed the title [wip] Split build & compilation verbosity control to two confs Split build & compilation verbosity control into two confs May 24, 2023
memsharded
memsharded approved these changes May 24, 2023
View reviewed changes

@memsharded memsharded left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good

Comment thread conans/test/functional/toolchains/cmake/test_cmake.py Outdated
@AbrilRBS
AbrilRBS merged commit 401220b into conan-io:release/2.0 May 31, 2023
@AbrilRBS AbrilRBS mentioned this pull request Jun 20, 2023
Merged
@BobIsOnFire BobIsOnFire mentioned this pull request Jul 13, 2023
Merged
2 tasks
@AbrilRBS AbrilRBS mentioned this pull request Mar 12, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franramirez688 franramirez688 franramirez688 approved these changes
@memsharded memsharded memsharded approved these changes
@SpaceIm SpaceIm Awaiting requested review from SpaceIm

Assignees

@AbrilRBS AbrilRBS

Labels

None yet

Projects

None yet

Milestone

2.0.7

Development

Successfully merging this pull request may close these issues.

[feature] conan 2.0 verbose build option for meson [feature] Allow users to enable verbose Makefile in CMakeToolchain

5 participants

@AbrilRBS @CLAassistant @franramirez688 @memsharded @SpaceIm