New revision_mode = scm_folder for monorepos - #13562
Merged
memsharded merged 3 commits intoMay 4, 2023
Merged
memsharded merged 3 commits into
memsharded merged 3 commits into
Conversation
memsharded
changed the title
revision_mode = scm_folder for monorepos
memsharded
marked this pull request as ready for review
April 26, 2023 18:44
memsharded
commented
May 3, 2023
| pref2.revision) | ||
|
|
||
|
|
||
| class SCMRevisions(unittest.TestCase): |
Member
Author
There was a problem hiding this comment.
These tests were redundant, consolidated them in the above tests
czoido
approved these changes
May 4, 2023
franramirez688
approved these changes
May 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: New
revision_mode = "scm_folder"for mono-repo projects that want to usescmrevisions.Docs: conan-io/docs#3218
This is a preliminary experiment to discuss about conan-io/docs#3135
The
revision_mode = "scm"doesn't work in mono-repo because it takes the root folder commit.The current PR approach is broken, as it will take the folder commit when the
conanfile.pyis inside a subfolder (this layout is allowed)