Skip to content

Proposal for sources backup feature - #13461

Merged
memsharded merged 57 commits into
conan-io:release/2.0from
memsharded:feature/backup_sources_upload
Mar 31, 2023
Merged

memsharded merged 57 commits into
conan-io:release/2.0from
memsharded:feature/backup_sources_upload

Conversation

@memsharded

@memsharded memsharded commented Mar 16, 2023

Copy link
Copy Markdown
Member

Changelog: Feature: Automatic server side source backups for third parties.
Docs: Omit

@memsharded memsharded added this to the 2.0.3 milestone Mar 16, 2023
@memsharded
memsharded requested a review from AbrilRBS March 29, 2023 11:24

@AbrilRBS AbrilRBS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worry about DownloadCache's state right now, but is in no way a blocker for me

Comment thread conans/client/downloaders/caching_file_downloader.py Outdated
Comment thread conans/client/downloaders/caching_file_downloader.py Outdated
Comment thread conans/client/downloaders/caching_file_downloader.py Outdated
@memsharded
memsharded requested a review from AbrilRBS March 30, 2023 07:23

@AbrilRBS AbrilRBS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the one. Congratulations on getting this thru the finish line :)

I think that the tests might need some love in the future, but we can live with some repetition in there for now. Let's see how this works for cci

from conans.util.sha import sha256 as compute_sha256


class DownloadCache:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants