Fix macOS <-> Linux cross cflags resolution - #13230
Merged
Merged
Conversation
Contributor
Author
|
ping |
Contributor
|
Hi @sfackler, thanks so much for your detailed report and for opening this PR. Indeed I believe the logic was not robust enough to account for the fact that you can target Linux from macOS. I have made a small fix to your PR - I believe the conditional should cover the case where
Note for @czoido: there's a chance this doesn't fully cover the case of targetting iOS from Linux (see https://github.com/tpoechtrager/cctools-port) - but this PR at least doesn't prevent that :D |
jcar87
approved these changes
Mar 13, 2023
memsharded
approved these changes
Mar 14, 2023
memsharded
left a comment
Member
There was a problem hiding this comment.
It would be great to add a test for this.
…etting non-Apple OS
AbrilRBS
approved these changes
Mar 14, 2023
czoido
approved these changes
Mar 14, 2023
franramirez688
added a commit
to franramirez688/conan
that referenced
this pull request
Mar 26, 2024
memsharded
pushed a commit
that referenced
this pull request
Mar 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Fix flags passed by AutotoolsToolchain when cross compiling from macOS to a non-Apple OS.
Docs: Omit
Fixes #13219
developbranch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.