Add settings to control screenshare quality#718
Conversation
|
can we get an experimental flatpak build for this? I would like to try this out :D |
| title: "Stream Resolution", | ||
| description: | ||
| "The resolution of your stream, higher is better", | ||
| options: [ |
There was a problem hiding this comment.
Some Device aren't 16/9. should there maybe be a free form selection, or some dynamic check, what the maximum possible resolution is of a source and based on that generate suggested lower resolutions?
There was a problem hiding this comment.
in my testing, this setting doesnt even really seem to effect the screenshare. I expected it to essentially pick a vertical resolution and maintain the correct aspect ratio, but not sure why its not having any effect at all
| description: | ||
| "Choose which format to encode your stream in. Different codecs may run faster on certain devices, and may be unsupported on others. Most devices should support vp8 and h264.", | ||
| options: [ | ||
| "h264", |
There was a problem hiding this comment.
livekit servers can block/allow only specific codes, is there maybe a way to populate the list dynamicly, by what is supported by the used livekit instance?
There was a problem hiding this comment.
The livekit client should automatically fall back to use a different codec if this is not supported, so i guess its more of a 'preferred codec' option
There was a problem hiding this comment.
prolly should be added into the description then that its just preffered?
https://github.com/commetchat/commet/actions/runs/22244426928 |
looks like the flatpak debug build is brocken: $ flatpak install --reinstall chat.commet.commetapp.flatpak
error: Invalid checksum of length 0 expected 32 |
|
also the protable version is double tared :D 
this makes normal tar -xzf fail btw, unless you specify another out dir, or rename the file xD even then, its not like I can actually use the "portable" build, as it has hard deps: $ ./commet
./commet: error while loading shared libraries: libdbus-1.so.3: cannot open shared object file: No such file or directory |
looks like github actions likes to play jokes: -> ive downloaded the flatpak. added the |
| DoublePreference("screenshare_fps", defaultValue: 60); | ||
|
|
||
| StringPreference streamCodec = | ||
| StringPreference("livekit_screenshare_codec", defaultValue: "h264"); |
There was a problem hiding this comment.
I suggest defaulting to av1 #450 (comment)
There was a problem hiding this comment.
Agreed, seems reasonable
|
I love this :D |
2 participants
Related to #450